[ https://issues.apache.org/jira/browse/KAFKA-5540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432913#comment-16432913 ]
Chris Egerton commented on KAFKA-5540: -------------------------------------- [~umesh9...@gmail.com] I've got an alternative PR opened up at [https://github.com/apache/kafka/pull/4693] that approaches the issue a little differently. Are you okay with moving forward on that PR instead of the one open at [https://github.com/apache/kafka/pull/4467] ? > Deprecate and remove internal converter configs > ----------------------------------------------- > > Key: KAFKA-5540 > URL: https://issues.apache.org/jira/browse/KAFKA-5540 > Project: Kafka > Issue Type: Bug > Components: KafkaConnect > Affects Versions: 0.11.0.0 > Reporter: Ewen Cheslack-Postava > Assignee: Chris Egerton > Priority: Major > Labels: needs-kip > Fix For: 1.2.0 > > > The internal.key.converter and internal.value.converter were original exposed > as configs because a) they are actually pluggable and b) providing a default > would require relying on the JsonConverter always being available, which > until we had classloader isolation it was possible might be removed for > compatibility reasons. > However, this has ultimately just caused a lot more trouble and confusion > than it is worth. We should deprecate the configs, give them a default of > JsonConverter (which is also kind of nice since it results in human-readable > data in the internal topics), and then ultimately remove them in the next > major version. > These are all public APIs so this will need a small KIP before we can make > the change. -- This message was sent by Atlassian JIRA (v7.6.3#76005)