vamossagar12 commented on code in PR #12561:
URL: https://github.com/apache/kafka/pull/12561#discussion_r974548386
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorIncrementalTest.java:
##########
@@ -517,13 +517,13 @@ public void testTaskAssignmentWhenWorkerBounces() {
leaderAssignment = deserializeAssignment(result, leaderId);
assertAssignment(leaderId, offset,
Collections.emptyList(), 0,
- Collections.emptyList(), 0,
+ Collections.emptyList(), 1,
Review Comment:
Yeah that's true. Revoking tasks at this point leads to imbalance. This was
happening since as per the new changes, the moment the delay expires we were
allowing revocation. So, at this point, the flag is true, the delay goes to 0
and since revocation is technically possible at this point, the code was doing
it. I have added the `canRevoke` flag back to handle this case with which this
testcase another test
`IncrementalCooperativeAssignorTest#testTaskAssignmentWhenWorkerBounces` which
seemed to have a similar issue seem to be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
