vamossagar12 commented on code in PR #12561:
URL: https://github.com/apache/kafka/pull/12561#discussion_r978581355
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorIncrementalTest.java:
##########
@@ -517,13 +517,13 @@ public void testTaskAssignmentWhenWorkerBounces() {
leaderAssignment = deserializeAssignment(result, leaderId);
assertAssignment(leaderId, offset,
Collections.emptyList(), 0,
- Collections.emptyList(), 0,
+ Collections.emptyList(), 1,
Review Comment:
Thanks Chris/Luke. I have revoked the `canRevoke` flag commit. Also, Chris,
I looked at your PR and it's closed but not merged. I see some changes
specially =>
```
Perform load-balancing revocations any time the cluster appears imbalanced
and there are still connectors and tasks that can be revoked from workers,
instead of only when the number of workers in the cluster changes
```
which sounds interesting (and remember discussing this on the ticket for
this). Also, let me know if there's anything I can also contribute to for the
other PR (Looking at your comment it appeared to me that you would be rebasing
the commits from that closed PR and hence the question).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
