[GitHub] [kafka] ahuang98 commented on a diff in pull request #12736: KAFKA-14292 controlledShutDownOffset should only be updated if set to -1

[GitBox]

ahuang98 commented on code in PR #12736:
URL: https://github.com/apache/kafka/pull/12736#discussion_r993968289


##########
metadata/src/main/java/org/apache/kafka/controller/BrokerHeartbeatManager.java:
##########
@@ -276,7 +277,7 @@ Collection<BrokerHeartbeatState> brokers() {
     }
 
     // VisibleForTesting
-    long getControlledShutDownOffset(int brokerId) {
+    long controlledShutDownOffset(int brokerId) {

Review Comment:
   hm, I think changing `controlledShutDownOffset()` to return 
`OptionalLong.empty()` instead of `-1` could be slightly unintuitive as `-1` 
was specifically allocated to mean the broker isn't currently in controlled 
shutdown. I think it would make more sense if the underlying field was also 
type `OptionalLong` and used `OptionalLong.empty()` instead of `-1`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org