showuon commented on code in PR #12736:
URL: https://github.com/apache/kafka/pull/12736#discussion_r994226194
##########
metadata/src/main/java/org/apache/kafka/controller/BrokerHeartbeatManager.java:
##########
@@ -400,12 +412,13 @@ long lowestActiveOffset() {
}
/**
- * Mark a broker as being in the controlled shutdown state.
+ * Mark a broker as being in the controlled shutdown state. We only update
the
+ * controlledShutdownOffset if the broker was previously not in controlled
shutdown state.
*
* @param brokerId The broker id.
* @param controlledShutDownOffset The offset at which controlled
shutdown will be complete.
*/
- void updateControlledShutdownOffset(int brokerId, long
controlledShutDownOffset) {
+ void maybeControlledShutdownOffset(int brokerId, long
controlledShutDownOffset) {
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
