soarez commented on code in PR #12789:
URL: https://github.com/apache/kafka/pull/12789#discussion_r1005027030
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java:
##########
@@ -691,7 +691,14 @@ protected Connector getConnector(String connType) {
* @param connClass class of the connector
*/
public ConnectorType connectorTypeForClass(String connClass) {
- return ConnectorType.from(getConnector(connClass).getClass());
+ if (connClass == null) {
+ return ConnectorType.UNKNOWN;
+ }
+ try {
+ return ConnectorType.from(getConnector(connClass).getClass());
+ } catch (ConnectException e) {
+ return ConnectorType.UNKNOWN;
Review Comment:
Should there be a debug or info level log with the exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
