C0urante commented on code in PR #12789:
URL: https://github.com/apache/kafka/pull/12789#discussion_r1006588134
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java:
##########
@@ -691,7 +691,14 @@ protected Connector getConnector(String connType) {
* @param connClass class of the connector
*/
public ConnectorType connectorTypeForClass(String connClass) {
Review Comment:
Do we even need this separate method anymore? It looks like it's only ever
called in tests. Can we inline this logic into `connectorTypeForConfig` and
tweak our tests to call that method instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
