[GitHub] [kafka] OmniaGM commented on a diff in pull request #12955: KAFKA-14443: Close topic creation Admin clients in MM2 connectors

[GitBox]

OmniaGM commented on code in PR #12955:
URL: https://github.com/apache/kafka/pull/12955#discussion_r1040002739


##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnector.java:
##########
@@ -159,8 +159,11 @@ Collection<ConsumerGroupListing> listConsumerGroups()
     }
 
     private void createInternalTopics() {
-        
MirrorUtils.createSinglePartitionCompactedTopic(config.checkpointsTopic(),
-            config.checkpointsTopicReplicationFactor(), 
config.forwardingAdmin(config.targetAdminConfig()));
+        MirrorUtils.createSinglePartitionCompactedTopic(
+                config.checkpointsTopic(),
+                config.checkpointsTopicReplicationFactor(),
+                sourceAdminClient
+        );

Review Comment:
   Why are we replacing the target admin client with the source admin client 
here?



##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnector.java:
##########
@@ -159,8 +159,11 @@ Collection<ConsumerGroupListing> listConsumerGroups()
     }
 
     private void createInternalTopics() {
-        
MirrorUtils.createSinglePartitionCompactedTopic(config.checkpointsTopic(),
-            config.checkpointsTopicReplicationFactor(), 
config.forwardingAdmin(config.targetAdminConfig()));
+        MirrorUtils.createSinglePartitionCompactedTopic(
+                config.checkpointsTopic(),
+                config.checkpointsTopicReplicationFactor(),
+                sourceAdminClient
+        );

Review Comment:
   You also might need to close the target admin client in this connector as 
well. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org