C0urante commented on PR #12955: URL: https://github.com/apache/kafka/pull/12955#issuecomment-1341129084
@ableegoldman Thanks for taking a look--I agree that a more thorough refactoring can wait for a follow-up PR. @gharris1727 I really like the general approach in the new `BackgroundResources` class and would love to still try to get something like it merged, but agree with your (and Sophie's) concerns about scope creep, especially with the upcoming release. Given that adding any sort of meaningful tests for a fix to this issue would require a non-negligible refactoring, and the simplicity of the original fix proposed here (which simply added a few instance variables to a few classes, all of which were closed later), I think we can revert this PR to its original approach and file a follow-up PR for more sophisticated resource-tracking later. We can plan to merge it to trunk only after the 3.4 branch has been cut. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
