hachikuji commented on code in PR #12968: URL: https://github.com/apache/kafka/pull/12968#discussion_r1044670130
########## core/src/main/scala/kafka/coordinator/transaction/ProducerIdManager.scala: ########## @@ -167,7 +167,7 @@ class RPCProducerIdManager(brokerId: Int, if (nextProducerId > currentProducerIdBlock.lastProducerId) { val block = nextProducerIdBlock.poll(maxWaitMs, TimeUnit.MILLISECONDS) if (block == null) { - throw Errors.REQUEST_TIMED_OUT.exception("Timed out waiting for next producer ID block") Review Comment: What I'm questioning is whether we want the exception to propagate all the way back to `KafakApis`, or if we want to handle it closer to the source. In other words, do we consider this an "unexpected" case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org