hachikuji commented on code in PR #12968: URL: https://github.com/apache/kafka/pull/12968#discussion_r1046275111
########## core/src/main/scala/kafka/coordinator/transaction/ProducerIdManager.scala: ########## @@ -167,7 +167,7 @@ class RPCProducerIdManager(brokerId: Int, if (nextProducerId > currentProducerIdBlock.lastProducerId) { val block = nextProducerIdBlock.poll(maxWaitMs, TimeUnit.MILLISECONDS) if (block == null) { - throw Errors.REQUEST_TIMED_OUT.exception("Timed out waiting for next producer ID block") Review Comment: I was just trying to figure out if we wanted the "unexpected error" message to be logged or not. Usually we try to catch errors in the handler. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org