satishd commented on code in PR #13046: URL: https://github.com/apache/kafka/pull/13046#discussion_r1059247572
########## core/src/main/scala/kafka/server/checkpoints/OffsetCheckpointFile.scala: ########## @@ -62,12 +62,17 @@ trait OffsetCheckpoint { * -----checkpoint file end---------- */ class OffsetCheckpointFile(val file: File, logDirFailureChannel: LogDirFailureChannel = null) { - val checkpoint = new CheckpointFileWithFailureHandler[(TopicPartition, Long)](file, OffsetCheckpointFile.CurrentVersion, + val checkpoint = new CheckpointFileWithFailureHandler[Tuple2[TopicPartition, Long]](file, OffsetCheckpointFile.CurrentVersion, Review Comment: Nice catch! This is not needed, it seemed to be part of earlier refactoring. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org