ijuma commented on code in PR #13046:
URL: https://github.com/apache/kafka/pull/13046#discussion_r1063708632
##########
core/src/main/scala/kafka/server/checkpoints/OffsetCheckpointFile.scala:
##########
@@ -65,9 +65,14 @@ class OffsetCheckpointFile(val file: File,
logDirFailureChannel: LogDirFailureCh
val checkpoint = new CheckpointFileWithFailureHandler[(TopicPartition,
Long)](file, OffsetCheckpointFile.CurrentVersion,
OffsetCheckpointFile.Formatter, logDirFailureChannel, file.getParent)
- def write(offsets: Map[TopicPartition, Long]): Unit =
checkpoint.write(offsets)
+ def write(offsets: Map[TopicPartition, Long]): Unit =
checkpoint.write(offsets.map{case (k, v)=> Tuple2(k, v)}.toSeq.asJava)
Review Comment:
The `map` operation is a `no-op` here since we are converting a tuple to a
tuple,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
