jolshan commented on code in PR #12901:
URL: https://github.com/apache/kafka/pull/12901#discussion_r1066377796
##########
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorAdapterTest.scala:
##########
@@ -58,7 +62,7 @@ class GroupCoordinatorAdapterTest {
@ApiKeyVersionsSource(apiKey = ApiKeys.JOIN_GROUP)
def testJoinGroup(version: Short): Unit = {
val groupCoordinator = mock(classOf[GroupCoordinator])
- val adapter = new GroupCoordinatorAdapter(groupCoordinator)
+ val adapter = new GroupCoordinatorAdapter(groupCoordinator, Time.SYSTEM)
Review Comment:
Curious if we wanted to mock time here. Doesn't seem to be a big difference
one way or the for most of these since they don't use a time component anyway,
but could be a good practice to have a MockTime. (Looks like we do use it for
the test added 😄 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
