jolshan commented on code in PR #12901:
URL: https://github.com/apache/kafka/pull/12901#discussion_r1067526170
##########
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorAdapterTest.scala:
##########
@@ -58,7 +62,7 @@ class GroupCoordinatorAdapterTest {
@ApiKeyVersionsSource(apiKey = ApiKeys.JOIN_GROUP)
def testJoinGroup(version: Short): Unit = {
val groupCoordinator = mock(classOf[GroupCoordinator])
- val adapter = new GroupCoordinatorAdapter(groupCoordinator)
+ val adapter = new GroupCoordinatorAdapter(groupCoordinator, Time.SYSTEM)
Review Comment:
Maybe I'm just recalling some recent tests where I used system time because
it was already there and it led to flakiness.
I suppose here though it is easier to switch so maybe not a problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
