ijuma commented on code in PR #13046:
URL: https://github.com/apache/kafka/pull/13046#discussion_r1070638073
##########
server-common/src/main/java/org/apache/kafka/server/common/CheckpointFile.java:
##########
@@ -72,7 +71,7 @@ public CheckpointFile(File file,
tempPath = Paths.get(absolutePath.toString() + ".tmp");
}
- public void write(Collection<T> entries) throws IOException {
+ public void write(List<T> entries) throws IOException {
Review Comment:
I don't think consistency is necessarily a goal in cases like this. The
original intent was to accept the minimal interface required, but to return
something more specific to avoid unnecessary conversions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
