hachikuji commented on code in PR #13192:
URL: https://github.com/apache/kafka/pull/13192#discussion_r1110445520
##########
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java:
##########
@@ -1249,7 +1263,7 @@ private ConsumerRecords<K, V> poll(final Timer timer,
final boolean includeMetad
//
// NOTE: since the consumed position has already been
updated, we must not allow
Review Comment:
I think you could argue the comment is still correct if possibly misleading.
We track the consumed position in the same field as the fetch position, but we
have indeed updated it at this point. And we might end up bringing back the old
field anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
