hachikuji commented on code in PR #13192:
URL: https://github.com/apache/kafka/pull/13192#discussion_r1110451025
##########
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java:
##########
@@ -1269,6 +1283,11 @@ private ConsumerRecords<K, V> poll(final Timer timer,
final boolean includeMetad
}
}
+ private int sendFetches() {
+ offsetFetcher.validatePositionsOnMetadataChange();
Review Comment:
The relocation of this makes me wonder if it's needed at all. We already
call the same method in `updateFetchPositions`, which is invoked prior to
`sendFetches`. I tried removing it locally and all tests still pass. Probably
not a good idea to remove here in the refactor, but maybe we could do it in a
follow-up. That would simplify the `OffsetFetcher` api a little.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
