vcrfxia commented on code in PR #13274: URL: https://github.com/apache/kafka/pull/13274#discussion_r1110457053
########## streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractReadOnlyDecorator.java: ########## @@ -68,6 +70,8 @@ public void close() { static StateStore getReadOnlyStore(final StateStore global) { if (global instanceof TimestampedKeyValueStore) { return new TimestampedKeyValueStoreReadOnlyDecorator<>((TimestampedKeyValueStore<?, ?>) global); + } else if (global instanceof VersionedKeyValueStore) { Review Comment: This addition, and the analogous one in `AbstractReadWriteDecorator`, is necessary so that `ProcessorContextImpl#getStateStore()` can properly return versioned stores. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org