mjsax commented on code in PR #13274:
URL: https://github.com/apache/kafka/pull/13274#discussion_r1123965019
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KeyValueStoreMaterializer.java:
##########
@@ -48,20 +55,30 @@ public StoreBuilder<TimestampedKeyValueStore<K, V>>
materialize() {
}
}
- final StoreBuilder<TimestampedKeyValueStore<K, V>> builder =
Stores.timestampedKeyValueStoreBuilder(
- supplier,
- materialized.keySerde(),
- materialized.valueSerde());
+ final StoreBuilder<?> builder;
+ if (supplier instanceof VersionedBytesStoreSupplier) {
+ builder = new VersionedKeyValueStoreBuilder<>(
+ (VersionedBytesStoreSupplier) supplier,
+ materialized.keySerde(),
+ materialized.valueSerde(),
+ Time.SYSTEM);
+ } else {
+ builder = Stores.timestampedKeyValueStoreBuilder(
+ supplier,
+ materialized.keySerde(),
+ materialized.valueSerde());
+ }
if (materialized.loggingEnabled()) {
builder.withLoggingEnabled(materialized.logConfig());
} else {
builder.withLoggingDisabled();
}
- if (materialized.cachingEnabled()) {
+ // versioned stores do not support caching
Review Comment:
Don't have a strong opinion. Pinging @guozhangwang and @vvcephei for input.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
