guozhangwang commented on PR #13190:
URL: https://github.com/apache/kafka/pull/13190#issuecomment-1440489302
Yeah I think it's okay to make the rule consistent, i.e. to honor the
timeout even under those four exceptions: if the timer has elapsed, then we
should well return from the loop in
```
client.poll(future, timer);
if (!future.isDone()) {
// we ran out of time
return false;
}
```
even if the response yet to be returned would contain any of these four
exceptions. So I think we should still obey this rule, i.e. even if a response
has been returned and we know it's going to be one of these four exceptions, if
the timer has elapsed, we still exit the loop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
