[GitHub] [kafka] philipnee commented on pull request #13190: KAFKA-12639: exit upon expired timer to prevent tight looping

[via GitHub]

philipnee commented on PR #13190:
URL: https://github.com/apache/kafka/pull/13190#issuecomment-1427307821

   Thanks @guozhangwang for the feedback - Added some tests there to cover the 
untesed cases.  I still have a quick question around this block, is it 
intentional to continue w/o sleep on the backoff timer? (quoting the original 
code)
   
   ```
   if (exception instanceof UnknownMemberIdException ||
                       exception instanceof IllegalGenerationException ||
                       exception instanceof RebalanceInProgressException ||
                       exception instanceof MemberIdRequiredException)
                       continue;
                   else if (!future.isRetriable())
                       throw exception;
   
                   timer.sleep(rebalanceConfig.retryBackoffMs);
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org