showuon commented on PR #13270:
URL: https://github.com/apache/kafka/pull/13270#issuecomment-1442732996
@RivenSun2 , I think what we're saying here, is we should throw exception in
main consumer thread for a short-term solution. That is, throwing exception in
`timeToNextHeartbeat` if heartbeat thread is failed. For your concern:
```
try {
consumer.poll(duration);
} catch (Exception e) {
log.error("has error when consumer poll!", e);
}
```
In this case, it'll be the consumer client's issue, not ours. The consumer
should handle each kind of exception differently, not just catch all exceptions
and keep retrying.
So, back to the original question, are you able to update the PR to throw
exception in `timeToNextHeartbeat` if heartbeat thread is failed? If you don't
have time, we can assign to other contributors. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
