philipnee commented on code in PR #13270: URL: https://github.com/apache/kafka/pull/13270#discussion_r1117263913
########## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ########## @@ -355,6 +355,12 @@ protected synchronized long timeToNextHeartbeat(long now) { // we don't need to send heartbeats if (state.hasNotJoinedGroup()) return Long.MAX_VALUE; + if (heartbeatThread != null) { Review Comment: We could 1 line it ya? ``` if (heartbeatThread != null && heartbeatThread.hasFailed()) { ... } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org