cmccabe commented on code in PR #13116:
URL: https://github.com/apache/kafka/pull/13116#discussion_r1127179616
##########
core/src/test/java/kafka/test/MockController.java:
##########
@@ -181,10 +194,16 @@ public CompletableFuture<Void> unregisterBroker(
static class MockTopic {
private final String name;
private final Uuid id;
+ private final int numPartitions;
MockTopic(String name, Uuid id) {
+ this(name, id, 10); // hard-code the number of partitions if left
unspecified
Review Comment:
I guess this is a nitpick but `num.partitions` defaults to 1, so having a
default of 10 partitions is a bit surprising here. Is there a reason to use 10
instead of 1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
