cmccabe commented on code in PR #13116:
URL: https://github.com/apache/kafka/pull/13116#discussion_r1127191300
##########
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##########
@@ -378,6 +378,118 @@ object TestUtils extends Logging {
props
}
+ def createCombinedControllerConfig(nodeId: Int,
Review Comment:
Can't we just add a boolean to `TestUtils.createBrokerConfig`? Two whole new
functions seems like overkill.
Also, while you're changing this code, it would be good to use the standard
indentation style. Having this be indented halfway through the page really
hurts the eyes. Thsee days we do:
```
def myVeryLongFunctionName(
foo: Foo,
bar: Bar,
...
quux: Quux
): ReturnValueType = {
...
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
