dajac commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1130670740
########## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java: ########## @@ -119,28 +131,52 @@ public boolean shouldClientThrottle(short version) { return version >= 4; } + public short version() { + return version; + } + public static class Builder { OffsetCommitResponseData data = new OffsetCommitResponseData(); HashMap<String, OffsetCommitResponseTopic> byTopicName = new HashMap<>(); + private final TopicResolver topicResolver; + private final short version; + + public Builder(TopicResolver topicResolver, short version) { Review Comment: I actually wonder if we should do it the other way around. We could do KAFKA-14793 first, merge it, and update this one accordingly. Without KAFKA-14793, the contract of the not really respected and it feels a bit weird to work around it here instead of fixing the real issue. Is KAFKA-14793 complicated? What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org