dajac commented on code in PR #13240:
URL: https://github.com/apache/kafka/pull/13240#discussion_r1130942769
##########
clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java:
##########
@@ -119,28 +131,52 @@ public boolean shouldClientThrottle(short version) {
return version >= 4;
}
+ public short version() {
+ return version;
+ }
+
public static class Builder {
OffsetCommitResponseData data = new OffsetCommitResponseData();
HashMap<String, OffsetCommitResponseTopic> byTopicName = new
HashMap<>();
+ private final TopicResolver topicResolver;
+ private final short version;
+
+ public Builder(TopicResolver topicResolver, short version) {
Review Comment:
The OffsetCommitValue part is not possible at the moment because we don’t
have a way to downgrade. My colleague @jeffkbkim works on a proposal for this.
We could start by either migrating from using TopicPartition to using
TopicIdPartition or handling this in the GroupCoordinatorAdaptor layer. The
former is likely simpler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
