[GitHub] [kafka] Hangleton commented on a diff in pull request #13378: KAFKA-14793 - Propagate Topic Ids to the Group Coordinator during Offsets Commit

[via GitHub]

Hangleton commented on code in PR #13378:
URL: https://github.com/apache/kafka/pull/13378#discussion_r1132525996


##########
core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala:
##########
@@ -1034,16 +1035,21 @@ private[group] class GroupCoordinator(
       if (validationErrorOpt.isDefined) {
         responseCallback(offsetMetadata.map { case (k, _) => k -> 
validationErrorOpt.get })
       } else {
+        // GroupMetadataManager does not support topic ids yet.

Review Comment:
   You are right, it is simpler to propagate one more layer until the final 
data is constructed. Thanks, updating the PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org