jolshan commented on code in PR #13323:
URL: https://github.com/apache/kafka/pull/13323#discussion_r1136146308
##########
clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java:
##########
@@ -302,6 +335,10 @@ public String toString() {
}
}
+ public static int replicaId(FetchRequestData fetchRequestData) {
+ return fetchRequestData.replicaId() != -1 ?
fetchRequestData.replicaId() : fetchRequestData.replicaState().replicaId();
Review Comment:
In the case of a consumer, we always read replica state (the second part of
the statement).
I don't think there are any bugs here, but it might be good to keep in mind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
