jolshan commented on code in PR #13323:
URL: https://github.com/apache/kafka/pull/13323#discussion_r1136245326
##########
clients/src/main/resources/common/message/FetchRequest.json:
##########
@@ -50,14 +50,23 @@
// Version 13 replaces topic names with topic IDs (KIP-516). May return
UNKNOWN_TOPIC_ID error code.
//
// Version 14 is the same as version 13 but it also receives a new error
called OffsetMovedToTieredStorageException(KIP-405)
- "validVersions": "0-14",
+ //
+ // Version 15 adds the ReplicaState which includes new field ReplicaEpoch
and the ReplicaId. Also,
+ // deprecate the old ReplicaId field and set its default value to -1.
(KIP-903)
+ "validVersions": "0-15",
"flexibleVersions": "12+",
"fields": [
{ "name": "ClusterId", "type": "string", "versions": "12+",
"nullableVersions": "12+", "default": "null",
"taggedVersions": "12+", "tag": 0, "ignorable": true,
"about": "The clusterId if known. This is used to validate metadata
fetches prior to broker registration." },
- { "name": "ReplicaId", "type": "int32", "versions": "0+", "entityType":
"brokerId",
+ { "name": "ReplicaId", "type": "int32", "versions": "0-14", "default":
"-1", "entityType": "brokerId",
"about": "The broker ID of the follower, of -1 if this request is from a
consumer." },
+ { "name": "ReplicaState", "type": "ReplicaState", "taggedVersions":"15+",
"tag": 1, "fields": [
Review Comment:
> Yes, when constructing an instance, it will do this.replicaState = new
ReplicaState()
The builder is still going to write to these feels as far as I can see in
the code. (FetchRequest line 266) Its just the case that these happen to be the
defaults and so the state is equal, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
