tinaselenge commented on code in PR #13373:
URL: https://github.com/apache/kafka/pull/13373#discussion_r1140270243
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java:
##########
@@ -539,11 +596,20 @@ Map<String, Config> describeTopicConfigs(Set<String>
topics)
}
Config targetConfig(Config sourceConfig) {
- List<ConfigEntry> entries = sourceConfig.entries().stream()
- .filter(x -> !x.isDefault() && !x.isReadOnly() && !x.isSensitive())
- .filter(x -> x.source() !=
ConfigEntry.ConfigSource.STATIC_BROKER_CONFIG)
- .filter(x -> shouldReplicateTopicConfigurationProperty(x.name()))
- .collect(Collectors.toList());
+ List<ConfigEntry> entries;
+ if (useIncrementalAlterConfigs ==
MirrorSourceConfig.NEVER_USE_INCREMENTAL_ALTER_CONFIG) {
Review Comment:
I have merged them and included conditional isDefault() check in the filter.
We basically want to always include default properties for
incrementalAlterConfigs API, and then shouldReplicateSourceDefault should
determine which operation should be used (SET/DELETE). For the deprecated API,
shouldReplicateSourceDefault would be used to filter default properties. We can
remove this filter, when we fully remove the deprecated API later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
