[GitHub] [kafka] tinaselenge commented on a diff in pull request #13373: Kafka-14420 Use incrementalAlterConfigs API for syncing topic configurations (KIP-894)

[via GitHub]

tinaselenge commented on code in PR #13373:
URL: https://github.com/apache/kafka/pull/13373#discussion_r1140303773


##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/DefaultConfigPropertyFilter.java:
##########
@@ -40,11 +44,13 @@ public class DefaultConfigPropertyFilter implements 
ConfigPropertyFilter {
                                                                    + 
"unclean\\.leader\\.election\\.enable, "
                                                                    + 
"min\\.insync\\.replicas";
     private Pattern excludePattern = 
MirrorUtils.compilePatternList(CONFIG_PROPERTIES_EXCLUDE_DEFAULT);
+    private String useDefaultsFrom = USE_DEFAULTS_FROM_DEFAULT;

Review Comment:
   It's used in configure() to read the properties and config is not global 
variable. If I make config private variable, remove and ` private String 
useDefaultsFrom`, then try to access config.useFromDefaults from 
`shouldReplicateSourceDefault()`, it doesn't seem to work. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org