tinaselenge commented on code in PR #13373: URL: https://github.com/apache/kafka/pull/13373#discussion_r1144973947
########## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/DefaultConfigPropertyFilter.java: ########## @@ -60,6 +65,11 @@ public boolean shouldReplicateConfigProperty(String prop) { return !excluded(prop); } + @Override + public boolean shouldReplicateSourceDefault(String prop) { + return useDefaultsFrom.equals("source"); Review Comment: I'm not sure about this, because shouldReplicateConfigProperty does that already. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org