C0urante commented on code in PR #13424:
URL: https://github.com/apache/kafka/pull/13424#discussion_r1145593098
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractStatus.java:
##########
@@ -24,8 +24,9 @@ public enum State {
UNASSIGNED,
RUNNING,
PAUSED,
+ STOPPED, // Only ever visible to users for Connector instances; never
for Task instances
Review Comment:
This class isn't part of the public API and I don't believe the ordinal
values for it are used anywhere internally, but it doesn't hurt to make this
change just in case. Good call, done 👍
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java:
##########
@@ -221,28 +223,44 @@ public boolean isRunning() {
}
@SuppressWarnings("fallthrough")
- private void pause() {
+ private void stop(boolean paused) {
Review Comment:
I do like `suspend` better than `stop`, but IMO it's not worth the extra
layer of indirection to add `stop` and `pause` methods that just delegate to
that method with a single parameter changed; might make the code base harder to
read for newcomers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
