C0urante commented on code in PR #13424: URL: https://github.com/apache/kafka/pull/13424#discussion_r1146277240
########## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectWorkerIntegrationTest.java: ########## @@ -325,6 +325,181 @@ public void testSourceTaskNotBlockedOnShutdownWithNonExistentTopic() throws Exce assertTrue("Connector and all tasks were not stopped in time", stopCounter.await(1, TimeUnit.MINUTES)); } + /** + * Verify that the target state (started, paused, stopped) of a connector can be updated, with + * an emphasis on ensuring that the transitions between each state are correct. + * <p> + * The transitions we need to cover are: + * <ol> + * <li>RUNNING -> PAUSED</li> + * <li>RUNNING -> STOPPED</li> + * <li>PAUSED -> RUNNING</li> + * <li>PAUSED -> STOPPED</li> + * <li>STOPPED -> RUNNING</li> + * <li>STOPPED -> PAUSED</li> + * </ol> + * With some reordering, we can perform each transition just once: + * <ul> + * <li>Start with RUNNING</li> + * <li>Transition to STOPPED (2)</li> + * <li>Transition to RUNNING (5)</li> + * <li>Transition to PAUSED (1)</li> + * <li>Transition to STOPPED (4)</li> + * <li>Transition to PAUSED (6)</li> + * <li>Transition to RUNNING (3)</li> + * </ul> + */ + @Test + public void testPauseStopResume() throws Exception { + connect = connectBuilder.build(); + // start the clusters + connect.start(); + + connect.assertions().assertAtLeastNumWorkersAreUp(NUM_WORKERS, + "Initial group of workers did not start in time."); + + // Want to make sure to use multiple tasks + final int numTasks = 4; + Map<String, String> props = defaultSourceConnectorProps(TOPIC_NAME); + props.put(TASKS_MAX_CONFIG, Integer.toString(numTasks)); Review Comment: > Or did you mean something like even if we wanted to change the default max tasks for other tests in this class, this one shouldn't be touched? Yep, exactly 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org