C0urante commented on code in PR #13424:
URL: https://github.com/apache/kafka/pull/13424#discussion_r1149776904
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java:
##########
@@ -237,6 +237,17 @@ private synchronized void putConnectorConfig(String
connName,
}
}
+ @Override
+ public synchronized void stopConnector(String connName, Callback<Void>
callback) {
+ try {
+ removeConnectorTasks(connName);
Review Comment:
> I guess this shouldn't really matter anyway because we're publishing an
empty set of task configs?
Exactly--and thanks to the logic introduced in the
[fix](https://github.com/apache/kafka/pull/8118) for
[KAFKA-9472](https://issues.apache.org/jira/browse/KAFKA-9472), once the
rebalance caused by the empty set of task configs has completed, the
`DistributedHerder` class will [automatically wipe the deleted tasks from the
status
store](https://github.com/apache/kafka/blob/31440b00f3ed8de65f368d41d6cf2efb07ca4a5c/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java#L2368).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
