cmccabe commented on code in PR #13374:
URL: https://github.com/apache/kafka/pull/13374#discussion_r1149876669
##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -128,6 +152,108 @@ object StorageTool extends Logging {
.getOrElse(defaultValue)
}
+ def getUserScramCredentialRecord(mechanism: String,
Review Comment:
There are a lot of contributors who are rewriting tools in Java right now.
You can take a look at the `git log` of the last month or two:
KAFKA-14578: Move ConsumerPerformance to tools (#13215)
KAFKA-14590: Move DelegationTokenCommand to tools (#13172)
KAFKA-14582: Move JmxTool to tools (#13136)
KAFKA-14575: Move ClusterTool to tools module (#13080)
MINOR: Move MetadataQuorumCommand from `core` to `tools` (#12951)
... etc ...
These rewrites aren't a "maybe someday" kind of thing; they are happening
right now.
Anyway, like I said earlier, we don't have to do that in this PR :) None of
this will be hard to port to Java when the time comes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
