cmccabe commented on code in PR #13374: URL: https://github.com/apache/kafka/pull/13374#discussion_r1149874897
########## core/src/main/scala/kafka/tools/StorageTool.scala: ########## @@ -22,19 +22,37 @@ import java.nio.file.{Files, Paths} import kafka.server.{BrokerMetadataCheckpoint, KafkaConfig, MetaProperties, RawMetaProperties} import kafka.utils.{Exit, Logging} import net.sourceforge.argparse4j.ArgumentParsers -import net.sourceforge.argparse4j.impl.Arguments.{store, storeTrue} +import net.sourceforge.argparse4j.impl.Arguments.{store, storeTrue, append} import net.sourceforge.argparse4j.inf.Namespace import org.apache.kafka.common.Uuid import org.apache.kafka.common.utils.Utils import org.apache.kafka.metadata.bootstrap.{BootstrapDirectory, BootstrapMetadata} -import org.apache.kafka.server.common.MetadataVersion +import org.apache.kafka.server.common.{ApiMessageAndVersion, MetadataVersion} +import org.apache.kafka.common.metadata.FeatureLevelRecord +import org.apache.kafka.common.metadata.UserScramCredentialRecord +import org.apache.kafka.common.security.scram.internals.ScramMechanism +import org.apache.kafka.common.security.scram.internals.ScramFormatter + +import java.util +import java.util.Base64 import java.util.Optional import scala.collection.mutable +import scala.jdk.CollectionConverters._ +import scala.collection.mutable.ArrayBuffer object StorageTool extends Logging { def main(args: Array[String]): Unit = { try { + main_internal(args) Review Comment: We don't use `snake_case`, we use `camelCase`. Also, it seems messy to have calls to `Exit.exit` both inside the "internal" function and outside it. It makes you wonder why we're bothering with the internal function. So what I'd sugest is: 1. rename `main_internal` to `run` or something like that 2. have `run` return the integer status code we should pass to `Exit.exit()` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org