junrao commented on code in PR #13463: URL: https://github.com/apache/kafka/pull/13463#discussion_r1156467080
########## core/src/main/scala/kafka/common/InterBrokerSender.scala: ########## @@ -156,6 +163,16 @@ abstract class InterBrokerSendThread( def wakeup(): Unit = networkClient.wakeup() } +abstract class InterBrokerRequestManager() { + + var interBrokerSender: InterBrokerSender = _ Review Comment: The issue is that `interBrokerSender` is being set and read in different threads. If there is no memory barrier, there is no guarantee that the reader will see the latest value being set. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org