jolshan commented on code in PR #13391:
URL: https://github.com/apache/kafka/pull/13391#discussion_r1160803600
##########
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##########
@@ -69,10 +108,23 @@ class KafkaRequestHandler(id: Int,
completeShutdown()
return
+ case request: RequestChannel.CallbackRequest =>
+ try {
+ request.originalRequest.callbackRequestDequeTimeNanos =
Some(time.nanoseconds())
+ request.fun()
+ request.originalRequest.callbackRequestCompleteTimeNanos =
Some(time.nanoseconds())
Review Comment:
Are you saying network client sends the response + updates the metrics
before we reach line 115, so we should put the complete message as part of the
response? I'm not sure the best way to put that in the callback. I'll have to
think about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
