jolshan commented on code in PR #13391:
URL: https://github.com/apache/kafka/pull/13391#discussion_r1160872423
##########
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##########
@@ -69,10 +108,23 @@ class KafkaRequestHandler(id: Int,
completeShutdown()
return
+ case request: RequestChannel.CallbackRequest =>
+ try {
+ request.originalRequest.callbackRequestDequeTimeNanos =
Some(time.nanoseconds())
Review Comment:
I think the issue is that the way that I implemented the metric is that we
only have callback start and end. If we wanted to store multiple callbacks, we
would need to change this. I'm tempted to tackle this sort of thing in a
followup change to avoid overcomplicating this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
