jolshan commented on code in PR #13391:
URL: https://github.com/apache/kafka/pull/13391#discussion_r1160896272
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -2334,6 +2334,10 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
+ // If this callback was executed after KafkaApis returned we will need
to adjust the callback completion time here.
+ if (request.callbackRequestDequeTimeNanos.isDefined)
+ request.callbackRequestCompleteTimeNanos = Some(time.nanoseconds())
+
Review Comment:
Hmm -- so we should only update if callback is also defined.
I'm also not sure about setting it twice, so we should only set after fun()
if it is not already set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
