[GitHub] [kafka] mjsax commented on a diff in pull request #13523: MINOR: Follow-up on failing streams test, and fix StoreChangelogReader

[via GitHub]

mjsax commented on code in PR #13523:
URL: https://github.com/apache/kafka/pull/13523#discussion_r1160998193


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java:
##########
@@ -880,6 +896,9 @@ private void initializeChangelogs(final Map<TaskId, Task> 
tasks,
     }
 
     private void addChangelogsToRestoreConsumer(final Set<TopicPartition> 
partitions) {
+        if (partitions.isEmpty())

Review Comment:
   > while the current assignment is also empty
   
   How do we know this? We did not get the assignment yet? Should this go after
   ```
   final Set<TopicPartition> assignment = new 
HashSet<>(restoreConsumer.assignment());
   
   if (partitions.isEmpty() && assignment.isEmpty()) {
     return;
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org