guozhangwang commented on code in PR #13523: URL: https://github.com/apache/kafka/pull/13523#discussion_r1162102863
########## streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java: ########## @@ -880,6 +896,9 @@ private void initializeChangelogs(final Map<TaskId, Task> tasks, } private void addChangelogsToRestoreConsumer(final Set<TopicPartition> partitions) { + if (partitions.isEmpty()) Review Comment: Yes that's right, but as long as `partitions.isEmpty()` then we could actually skip the whole func, so I made it applied at larger scope. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org