cmccabe commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1163305761
##########
metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java:
##########
@@ -266,6 +311,11 @@ private ApiError updateMetadataVersion(
new FeatureLevelRecord()
.setName(MetadataVersion.FEATURE_NAME)
.setFeatureLevel(newVersionLevel),
FEATURE_LEVEL_RECORD.lowestSupportedVersion()));
+
+ // If we are moving to a version that supports migrations, we need to
write the correct state into the log
Review Comment:
Actually, that's not quite true... we should return an error if someone is
trying to change metadataversion and we're in a state other than NONE or
POST_MIGRATION. Since changing MV during a migration is a big headache and we
agreed to disable that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
