rreddy-22 commented on code in PR #13524:
URL: https://github.com/apache/kafka/pull/13524#discussion_r1164535218
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentSpec.java:
##########
@@ -28,12 +28,12 @@ public class AssignmentSpec {
/**
* The members keyed by member id.
*/
- final Map<String, AssignmentMemberSpec> members;
+ private final Map<String, AssignmentMemberSpec> members;
/**
* The topics' metadata keyed by topic id
*/
- final Map<Uuid, AssignmentTopicMetadata> topics;
+ private final Map<Uuid, AssignmentTopicMetadata> topics;
Review Comment:
I didn't think about the full implementation yet and where the rackIds will
be passed, figured we could edit it when it came to implementing the algorithm.
The topicIdToPartition data structure could be populated using this so maybe we
can add a field for a map of partition to its rackIds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
