dajac commented on code in PR #13524:
URL: https://github.com/apache/kafka/pull/13524#discussion_r1165149138
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/MemberAssignment.java:
##########
@@ -54,6 +60,6 @@ public int hashCode() {
@Override
public String toString() {
- return "MemberAssignment(targetPartitions=" + targetPartitions + ')';
+ return "MemberAssignment (Target partitions = " + targetPartitions +
')';
Review Comment:
nit: The format does not follow our convention whereas the former code did.
Could we revert this line back?
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentTopicMetadata.java:
##########
@@ -25,12 +25,12 @@ public class AssignmentTopicMetadata {
/**
* The topic name.
*/
- final String topicName;
+ private final String topicName;
Review Comment:
I would remove it because I don't really see the value of having it. All the
interface works with topic ids now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
