philipnee commented on code in PR #13477:
URL: https://github.com/apache/kafka/pull/13477#discussion_r1167062912
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java:
##########
@@ -212,11 +212,11 @@ public <K, V> void send(final String topic,
keyClass,
valueClass),
exception);
- } catch (final SerializationException exception) {
+ } catch (final Exception exception) {
Review Comment:
@mjsax - I guess the intention is to catch all other errors during
serialization, not just the serialization exception. I think this is fine, I
don't know if there are exceptions but I guess not: seems like the handler
should either indicating there's an error and rethrow or continue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
