philipnee commented on code in PR #13477:
URL: https://github.com/apache/kafka/pull/13477#discussion_r1167095917
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java:
##########
@@ -212,11 +212,11 @@ public <K, V> void send(final String topic,
keyClass,
valueClass),
exception);
- } catch (final SerializationException exception) {
+ } catch (final Exception exception) {
Review Comment:
Not sure what you mean by this? Can you elaborate? If the handler itself
fail, we throw. If the handler returns FAIL we also re-throw the exception
(just wrapped as StreamsException). If the handler return CONTINUE we log a
WARN and continue (via return).
thanks that's exactly what I meant/trying to ask. sorry about not being
clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
